Skip to content

Conversation

SuperKali
Copy link
Member

Description

This PR contains the rewritten DTS to enable current mainline implementations for the NanoPi R76S board, allowing kernel edge support.

How Has This Been Tested?

  • ./compile.sh BOARD=nanopi-r76s BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no COMPRESS_OUTPUTIMAGE=img,xz KERNEL_CONFIGURE=no RELEASE=trixie KERNEL_GIT=shallow
  • https://paste.armbian.com/aqovuqobuv

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Copy link
Contributor

coderabbitai bot commented Sep 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates config/boards/nanopi-r76s.conf by changing KERNEL_TARGET from "vendor" to "vendor,edge" and updates the adjacent comment from "WIP: current & edge kernel" to "WIP: current kernel". No other files or variables are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • prahal
  • rpardini
  • krachlatte
  • igorpecovnik
  • catalinii
  • Tonymac32
  • HeyMeco
  • chainsx
  • clee

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6df468d and e9af24a.

⛔ Files ignored due to path filters (1)
  • patch/kernel/archive/rockchip64-6.16/dt/rk3576-nanopi-r76s.dts is excluded by !patch/**
📒 Files selected for processing (1)
  • config/boards/nanopi-r76s.conf (1 hunks)
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/large PR with 250 lines or more 11 Milestone: Fourth quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 11, 2025
@coderabbitai coderabbitai bot requested a review from ginkage September 11, 2025 05:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c51907d and 6df468d.

⛔ Files ignored due to path filters (1)
  • patch/kernel/archive/rockchip64-6.16/dt/rk3576-nanopi-r76s.dts is excluded by !patch/**
📒 Files selected for processing (1)
  • config/boards/nanopi-r76s.conf (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: leggewie
PR: armbian/build#8524
File: config/boards/orangepi2.csc:6-6
Timestamp: 2025-08-21T08:10:59.502Z
Learning: Not all Armbian boards support all kernel versions (legacy, current, edge). Some boards may only support specific kernel versions due to hardware limitations or lack of mainline support, which is why their KERNEL_TARGET contains only the supported options (e.g., just "legacy").
📚 Learning: 2025-08-21T08:10:59.502Z
Learnt from: leggewie
PR: armbian/build#8524
File: config/boards/orangepi2.csc:6-6
Timestamp: 2025-08-21T08:10:59.502Z
Learning: Not all Armbian boards support all kernel versions (legacy, current, edge). Some boards may only support specific kernel versions due to hardware limitations or lack of mainline support, which is why their KERNEL_TARGET contains only the supported options (e.g., just "legacy").

Applied to files:

  • config/boards/nanopi-r76s.conf
📚 Learning: 2025-06-25T03:42:09.086Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.

Applied to files:

  • config/boards/nanopi-r76s.conf
📚 Learning: 2025-08-02T05:46:10.664Z
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-08-02T05:46:10.664Z
Learning: In the Armbian build system, the modern recommended approach for kernel configuration is to use the kernel-config command via "./compile.sh BOARD=boardname BRANCH=branchname kernel-config" instead of the deprecated KERNEL_CONFIGURE=yes flag. This provides a two-step workflow: configure using menuconfig, then build, with better transparency and control over configuration changes.

Applied to files:

  • config/boards/nanopi-r76s.conf
📚 Learning: 2025-06-25T03:40:52.109Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.

Applied to files:

  • config/boards/nanopi-r76s.conf
📚 Learning: 2025-05-05T12:35:07.143Z
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.

Applied to files:

  • config/boards/nanopi-r76s.conf
🧬 Code graph analysis (1)
config/boards/nanopi-r76s.conf (3)
config/sources/vendors/microsoft/wsl2.hooks.sh (1)
  • post_family_config_branch_edge__wsl2 (21-26)
lib/functions/compilation/armbian-kernel.sh (2)
  • armbian_kernel_config__netkit (46-53)
  • armbian_kernel_config__extrawifi_enable_wifi_opts_80211 (24-36)
lib/functions/configuration/main-config.sh (1)
  • write_config_summary_output_file (488-541)
🔇 Additional comments (1)
config/boards/nanopi-r76s.conf (1)

5-5: Edge support via KERNEL_TARGET looks good

Adding edge aligns with the PR goal. No extra KERNELSOURCE needed; mainline fallback will handle edge for rk35xx.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 11, 2025
@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Sep 11, 2025
@SuperKali SuperKali merged commit 471aba8 into armbian:main Sep 11, 2025
8 of 9 checks passed
@SuperKali SuperKali deleted the nanopi-r76s-edge branch September 11, 2025 07:03
@coderabbitai coderabbitai bot requested a review from igorpecovnik September 11, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants