-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
add NanoPi R76S support for edge kernel builds #8609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request updates config/boards/nanopi-r76s.conf by changing KERNEL_TARGET from "vendor" to "vendor,edge" and updates the adjacent comment from "WIP: current & edge kernel" to "WIP: current kernel". No other files or variables are modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
patch/kernel/archive/rockchip64-6.16/dt/rk3576-nanopi-r76s.dts
is excluded by!patch/**
📒 Files selected for processing (1)
config/boards/nanopi-r76s.conf
(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: leggewie
PR: armbian/build#8524
File: config/boards/orangepi2.csc:6-6
Timestamp: 2025-08-21T08:10:59.502Z
Learning: Not all Armbian boards support all kernel versions (legacy, current, edge). Some boards may only support specific kernel versions due to hardware limitations or lack of mainline support, which is why their KERNEL_TARGET contains only the supported options (e.g., just "legacy").
📚 Learning: 2025-08-21T08:10:59.502Z
Learnt from: leggewie
PR: armbian/build#8524
File: config/boards/orangepi2.csc:6-6
Timestamp: 2025-08-21T08:10:59.502Z
Learning: Not all Armbian boards support all kernel versions (legacy, current, edge). Some boards may only support specific kernel versions due to hardware limitations or lack of mainline support, which is why their KERNEL_TARGET contains only the supported options (e.g., just "legacy").
Applied to files:
config/boards/nanopi-r76s.conf
📚 Learning: 2025-06-25T03:42:09.086Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Applied to files:
config/boards/nanopi-r76s.conf
📚 Learning: 2025-08-02T05:46:10.664Z
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-08-02T05:46:10.664Z
Learning: In the Armbian build system, the modern recommended approach for kernel configuration is to use the kernel-config command via "./compile.sh BOARD=boardname BRANCH=branchname kernel-config" instead of the deprecated KERNEL_CONFIGURE=yes flag. This provides a two-step workflow: configure using menuconfig, then build, with better transparency and control over configuration changes.
Applied to files:
config/boards/nanopi-r76s.conf
📚 Learning: 2025-06-25T03:40:52.109Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Applied to files:
config/boards/nanopi-r76s.conf
📚 Learning: 2025-05-05T12:35:07.143Z
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
Applied to files:
config/boards/nanopi-r76s.conf
🧬 Code graph analysis (1)
config/boards/nanopi-r76s.conf (3)
config/sources/vendors/microsoft/wsl2.hooks.sh (1)
post_family_config_branch_edge__wsl2
(21-26)lib/functions/compilation/armbian-kernel.sh (2)
armbian_kernel_config__netkit
(46-53)armbian_kernel_config__extrawifi_enable_wifi_opts_80211
(24-36)lib/functions/configuration/main-config.sh (1)
write_config_summary_output_file
(488-541)
🔇 Additional comments (1)
config/boards/nanopi-r76s.conf (1)
5-5
: Edge support via KERNEL_TARGET looks goodAdding edge aligns with the PR goal. No extra KERNELSOURCE needed; mainline fallback will handle edge for rk35xx.
6df468d
to
e9af24a
Compare
Description
This PR contains the rewritten DTS to enable current mainline implementations for the NanoPi R76S board, allowing kernel edge support.
How Has This Been Tested?
./compile.sh BOARD=nanopi-r76s BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no COMPRESS_OUTPUTIMAGE=img,xz KERNEL_CONFIGURE=no RELEASE=trixie KERNEL_GIT=shallow
Checklist: