Skip to content

fix(ci): run tests with a $DISPLAY for the release build #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(ci): run tests with a $DISPLAY for the release build #45

merged 1 commit into from
Dec 13, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Dec 13, 2023 •
edited
Loading

This project has not had integration tests before #41. Now, tests run, but they fail on Linux due to the missing X Server or display.

Changes:

  • Run tests with a display
  • Run all tests
  • Bump version to match the next tag

@kittaakos kittaakos requested a review from umbynos December 13, 2023 14:55
@kittaakos kittaakos merged commit 1437f94 into main Dec 13, 2023
@kittaakos kittaakos deleted the fix-deploy-ci branch December 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kittaakos @umbynos