Abort rather than calling arduino-cli compile with a blank --fqbn #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: enhancement
mbacarella
force-pushed
the
validate-fqbn-before-compile
branch
from
4b3f6c4 to
c5efd3e
Compare
The server calls arduino-cli compile --fqbn even if fqbn is not known, which leads to more confusing errors. Abort earlier and explain what to do (call the server with -fqbn instead).
mbacarella
force-pushed
the
validate-fqbn-before-compile
branch
from
c5efd3e to
6a51e4e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before creating one)
Validates configuration.
The server calls arduino-cli compile --fqbn even if fqbn is not known, which leads to more confusing errors.
Previously mentioned here #207. Also related to #215.
Fixes #207.
Abort earlier and explain what to do (call the server with -fqbn instead or set default_fqbn in sketch.yaml).