Skip to content

Remove conformance to AlgebraicField on Quaternion #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Remove conformance to AlgebraicField on Quaternion #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055a5fe
Remove AlgebraicField conformance on quaternions
markuswntr Apr 26, 2022
ad734eb
Merge branch 'quaternions' into quaternion/division-algebra
markuswntr Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ionModule/Quaternion+AlgebraicField.swift → ...nionModule/Quaternion+SignedNumeric.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//===--- Quaternion+AlgebraicField.swift ----------------------*- swift -*-===//
//===--- Quaternion+SignedNumeric.swift -----------------------*- swift -*-===//
//
// This source file is part of the Swift Numerics open source project
//
Expand All @@ -9,9 +9,7 @@
//
//===----------------------------------------------------------------------===//

import RealModule

extension Quaternion: AlgebraicField {
extension Quaternion: SignedNumeric {
/// The multiplicative identity, with real part one and *all* imaginary parts
/// zero, i.e.: `1 + 0i + 0j + 0k`
///
Expand Down