Skip to content

fix: can't run unit tests in docker #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 30, 2025
Merged

fix: can't run unit tests in docker #600

merged 11 commits into from
Sep 30, 2025

Conversation

bliuchak
Copy link
Contributor

@bliuchak bliuchak commented Sep 26, 2025 •
edited
Loading

This PR fix Dockerfile and allows unit tests to run inside a container gracefully. Also it specifies a node.js version 18 into .nvmrc file to ensure compatibility. Discussed later with Jirka that it's better not to have this file. All the tests must be fixed and should be compatible with newer versions of node all the time.

Resolves: #599

@bliuchak bliuchak added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. labels Sep 26, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Sep 26, 2025
@bliuchak bliuchak changed the title chore: specify node version using .nvmrc fix: can't run unit tests in docker Sep 26, 2025
@jirimoravcik
Copy link
Member

SOCKS test is failing in CI

@bliuchak
Copy link
Contributor Author

@jirimoravcik should be fixed now.

jirimoravcik
jirimoravcik reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add tests for newer Node.js versions in the CI? Now we have 14, 16, 18. Let's add 20, 22, 24 (soon LTS)

@bliuchak
Copy link
Contributor Author

I've already checked node 22 and tests are failing there due to few breakable changes (e.g. node 22 don't allow us to response with status code 55). I'd open a new issue for it if you don't mind.

@jirimoravcik
Copy link
Member

I've already checked node 22 and tests are failing there due to few breakable changes (e.g. node 22 don't allow us to response with status code 55). I'd open a new issue for it if you don't mind.

Yes, that's fine

@bliuchak
Copy link
Contributor Author

Here's issue about node version upgrade: #601

jirimoravcik
jirimoravcik requested changes Sep 29, 2025
View reviewed changes
@jirimoravcik jirimoravcik self-requested a review September 29, 2025 20:48
lewis-wow
lewis-wow approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@lewis-wow lewis-wow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@bliuchak bliuchak merged commit 8e3142b into master Sep 30, 2025
5 checks passed
@bliuchak bliuchak deleted the fix/unit-tests branch September 30, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

@lewis-wow lewis-wow lewis-wow approved these changes

Assignees

@bliuchak bliuchak

Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-core-services Issues with this label are in the ownership of the core services team. t-unblocking Issues with this label are in the ownership of the unblocking team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
124th sprint - Core Services team
Development

Successfully merging this pull request may close these issues.

Unit tests are failing
3 participants
@bliuchak @jirimoravcik @lewis-wow