refactor!: сhange default incognito context to persistent context for Playwright
#985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
requested review from
vdusek and
Pijukatel
and removed request for
vdusek
Mantisus
changed the title
Playwrightincognito context to persistent context for Playwright
vdusek
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Since it contains a breaking change, could you please describe the breaking changes in the PR's description and also summarize it in the Upgrading guide?
Pijukatel
requested changes
Feb 19, 2025
Pijukatel
reviewed
Feb 19, 2025
Co-authored-by: Vlada Dusek <[email protected]>
Co-authored-by: Vlada Dusek <[email protected]>
Co-authored-by: Vlada Dusek <[email protected]>
### Description - fix public imports in `__init__` files - Add `rich` to direct dependencies. It is one of `cookiecutter`'s dependencies, but we use it directly in `statistics._models.py` --------- Co-authored-by: Vlada Dusek <[email protected]>
### Description Add adaptive context helpers and documentation for AdaptivePlaywrightCrawler. ### Issues - Closes: apify#249 --------- Co-authored-by: Jan Buchar <[email protected]> Co-authored-by: Jan Buchar <[email protected]>
### Description - update curl-cffi version requirement to >=0.9.0. - update default `impersonate` from `chrome124` to `chrome131`
- Migrate from `poetry` to `uv`. - Relates: apify#628 - The update of templates to use `uv` will be implemented separately.
- `project.urls` - python 3.13 in ci - unify name "Set up uv package manager" - fix contributing guide - add all extra, remove dev extra (move to dev deps) - relates: apify#628
…pify#959) Add `additional_http_error_status_codes` and `ignore_http_error_status_codes` to PlaywrightCrawler. Since they exist now on all crawlers, move them to `BasicCrawler` level. Do not use `_http_client` attributes for getting additional status codes related variables. **Breaking:** Remove `HttpCrawlerOptions` -> No unique options compared to `BasicCrawlerOptions` anymore. - Closes: apify#953
vdusek
reviewed
Feb 20, 2025
Mantisus
force-pushed
the
pw-persist-browser-context
branch
from
6b6236d to
5e97e31
Compare
The problem is not related to this PR. It's solved in the PR #1007 |
Pijukatel
reviewed
Feb 21, 2025
Pijukatel
approved these changes
Feb 24, 2025
vdusek
requested changes
Feb 24, 2025
Co-authored-by: Vlada Dusek <[email protected]>
vdusek
modified the milestones:
108th sprint - Tooling team,
109th sprint - Tooling team
vdusek
added
the
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PlaywrightCrawlerfrom using the standard browser context to using a persistent browser context.user_data_dirwith the path to the directory for the context. Ifuser_data_diris not provided, a temporary directory will be created.Issues