Skip to content

fix: fix session managment with retire #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: fix session managment with retire #947

merged 1 commit into from
Jan 31, 2025

Conversation

Mantisus
Copy link
Collaborator

Description

  • Fix cases where a session was not excluded from the pool after calling session.retire() inside a successful request_handler.

@Mantisus Mantisus mentioned this pull request Jan 30, 2025
Merged
@Mantisus Mantisus requested a review from janbuchar January 30, 2025 17:35
@Mantisus Mantisus self-assigned this Jan 30, 2025
vdusek
vdusek approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vdusek vdusek merged commit caee03f into apify:master Jan 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@Mantisus Mantisus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mantisus @janbuchar @vdusek