Skip to content

Conversation

Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Jan 9, 2025

Description

  • fix for proxy in PlaywrightCrawler

Issues

Testing

  • Added test to verify proxy is correctly set for PlaywrightCrawler

@Mantisus Mantisus self-assigned this Jan 9, 2025
@B4nan B4nan changed the title fix: restore proxy functionality for PlaywrightCrawler broken in 5.0 fix: restore proxy functionality for PlaywrightCrawler broken in v0.5 Jan 9, 2025
@janbuchar janbuchar requested review from Pijukatel and vdusek and removed request for Pijukatel January 9, 2025 16:28
@Mantisus Mantisus requested a review from vdusek January 10, 2025 08:54
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 908c944 into apify:master Jan 15, 2025
23 checks passed
@vdusek vdusek added this to the 106th sprint - Tooling team milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A proxy created with param proxy_urls crashes PlaywrightCrawler
3 participants