fix: pass verify in httpx client
#802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we all agree that we're not ready to add custom transport support #801, I think this PR is ready for review in its current form. |
janbuchar
reviewed
Dec 11, 2024
| ignore_http_error_status_codes: Iterable[int] = (), | ||
| http1: bool = True, | ||
| http2: bool = True, | ||
| verify: str | bool | SSLContext = True, |
There was a problem hiding this comment.
I know that this is the name of the attribute in httpx, but maybe we could rename this to something like verify_certificates or verify_ssl for better clarity?
There was a problem hiding this comment.
These names are indeed clearer.
But as a weak argument. The requests API, has become such a standard for HTTP clients in Python that any Python developer, will expect exactly verify.
janbuchar
approved these changes
Dec 13, 2024
vdusek
added
the
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
verifytotransportinHttpxHttpClientIssues
verifyfield is not being propagated #798Checklist