Skip to content

fix: force quit stuck Actor.exit() calls #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

fix: force quit stuck Actor.exit() calls #420

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5916540
fix: force quit stuck `Actor.exit()` calls
barjin Jul 30, 2025
f7cf97a
chore: revert unrelated changes
barjin Jul 30, 2025
8ab7581
chore: remove non-null assertion
barjin Jul 30, 2025
639ad77
chore: better comments
barjin Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/apify/src/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,15 @@ export class Actor<Data extends Dictionary = Dictionary> {
log.debug(
`Waiting for all event listeners to complete their execution (with ${options.timeoutSecs} seconds timeout)`,
);

if (options.exit) {
// `addTimeoutToPromise` is a cooperative timeout. This ensures that the process exits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if something hogs the event loop with something CPU-intensive, the setTimeout won't fire, but this surely is better than the previous state

// after the timeout, even if the event listeners don't trigger the timeout.
setTimeout(() => {
process.exit(options.exitCode);
}, options.timeoutSecs * 1000);
}

await addTimeoutToPromise(
async () => {
await events.waitForAllListenersToComplete();
Expand Down
Loading