fix: force quit stuck Actor.exit() calls
#420
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Actor.exit() calls could get stuck for extended periods (up to an hour) before the platform migration occurs. The fix adds a hard timeout mechanism to ensure the process exits within the specified timeout period.
- Adds a
setTimeoutthat forcesprocess.exit()after the timeout period - Ensures the timeout only applies when
options.exitis true - Places the forced exit in the event loop before potentially time-consuming operations
janbuchar
approved these changes
Jul 30, 2025
| ); | ||
|
|
||
| if (options.exit) { | ||
| // `addTimeoutToPromise` is a cooperative timeout. This ensures that the process exits |
There was a problem hiding this comment.
Well, if something hogs the event loop with something CPU-intensive, the setTimeout won't fire, but this surely is better than the previous state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered in https://console.apify.com/view/runs/ZlPUJOjFTsIHzH8dP
WARN Main crawler finished successfully, exiting the run...is the last log line before theActor.exit()call. The internals of the call seem to be blocking execution for ~1 hour, before the Platform migrates.These changes place the
process.exit()call into the event loop before any potentially time-consuming operations.