Skip to content

Conversation

JMatej
Copy link
Contributor

@JMatej JMatej commented Sep 10, 2025

@honzajavorek Couple of fixes and updated screenshots. If you have any questions just tag me, but I think they are pretty straightforward.

@JMatej JMatej changed the title fix: mix of small improvments fix: mix of small improvements Sep 10, 2025
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but now Vale will be screaming murder about H1's with new rule it's ✅ from me

@TC-MO
Copy link
Contributor

TC-MO commented Oct 7, 2025

I can take a look later today and fix vale issues, from what I saw it is just screaming about H1's

@JMatej
Copy link
Contributor Author

JMatej commented Oct 7, 2025

@TC-MO I fixed vale's H1 warnings.

@TC-MO
Copy link
Contributor

TC-MO commented Oct 8, 2025

Just FYI @JMatej in this case it is actually better to remove H1's instead of turning them into H1's.

Docusaurus will create H1 automatically based on title property from frontmatter so we will have now in those files H1 generated from title and immediately below H2 that is exactly the same.

@JMatej
Copy link
Contributor Author

JMatej commented Oct 8, 2025

@TC-MO My bad, should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants