Skip to content

feat: Improve description for MCP server tools configuration #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 8, 2025
Merged

feat: Improve description for MCP server tools configuration #1773

merged 9 commits into from
Aug 8, 2025

Conversation

jirispilka
Copy link
Contributor

@jirispilka jirispilka commented Aug 7, 2025 •
edited
Loading

It should have only been a Section change (see context: https://apify.slack.com/archives/C08N1LWC596/p1753972689045599).

But while I was at it, I took the liberty to make some changes to improve clarity.

What I didn’t like about the current state:

  • Tool configuration was mixed into the Dynamic .... section.
  • Tool descriptions were essentially duplicated: once when describing the tools themselves, and again when describing the parameter that enabled the tools.

Link to the updated doc: https://pr-1773.preview.docs.apify.com/platform/integrations/mcp#configure-tools-for-mcp-server

@jirispilka jirispilka requested a review from TC-MO as a code owner August 7, 2025 15:10
@jirispilka jirispilka self-assigned this Aug 7, 2025
@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Aug 7, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 85506f38 and is ready at https://pr-1773.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 011659e5 and is ready at https://pr-1773.preview.docs.apify.com!

@cursor Cursor
Copy link

cursor bot commented Aug 7, 2025

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@apify-service-account
Copy link

Preview for this PR was built for commit c2b1c851 and is ready at https://pr-1773.preview.docs.apify.com!

@jirispilka jirispilka requested review from MQ37 and jancurn August 7, 2025 15:27
jancurn
jancurn reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jirka, just a few comments

@MQ37 MQ37 mentioned this pull request Aug 8, 2025
Closed
MQ37
MQ37 approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready after addressing the missing tools options and JC comments

jancurn
jancurn reviewed Aug 8, 2025
View reviewed changes
jancurn
jancurn reviewed Aug 8, 2025
View reviewed changes
@jancurn
Copy link
Member

jancurn commented Aug 8, 2025

cool, cheers, I might also do one more iteration later

@apify-service-account
Copy link

Preview for this PR was built for commit 31da0183 and is ready at https://pr-1773.preview.docs.apify.com!

@jirispilka
Copy link
Contributor Author

jirispilka commented Aug 8, 2025 •
edited
Loading

cool, cheers, I might also do one more iteration later

Yes, please, looking at it with fresh eyes, this is clearly more complicated than it should be.
It should be:

  • Quick start guide with simple examples to get started
  • Configuration
  • More examples with use cases, so people can just copy-paste

TC-MO
TC-MO requested changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes for conciness & questions.
I also noticed few other things that I'll tackle in separate documents since they are unrelated here.

@apify-service-account
Copy link

Preview for this PR was built for commit efc9894a and is ready at https://pr-1773.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 00ba54bc and is ready at https://pr-1773.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 28e74ca5 and is ready at https://pr-1773.preview.docs.apify.com!

TC-MO
TC-MO reviewed Aug 8, 2025
View reviewed changes
TC-MO
TC-MO approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jirispilka
Copy link
Contributor Author

Thanks everyone! It’s never as simple as it seems, you always need to think twice before saying, “let’s just quickly fix this.” 😄

@jirispilka jirispilka merged commit a9fb17c into master Aug 8, 2025
10 checks passed
@jirispilka jirispilka deleted the fix/mcp-config-section branch August 8, 2025 14:33
daveomri pushed a commit to daveomri/apify-docs that referenced this pull request Sep 3, 2025
@jirispilka @TC-MO @daveomri
feat: Improve description for MCP server tools configuration (apify#1773
3d0e747 
)

It should have only been a Section change (see context:
https://apify.slack.com/archives/C08N1LWC596/p1753972689045599).

But while I was at it, I took the liberty to make some changes to
improve clarity.

What I didn’t like about the current state:

- Tool configuration was mixed into the Dynamic .... section.
- Tool descriptions were essentially duplicated: once when describing
the tools themselves, and again when describing the parameter that
enabled the tools.

Link to the updated doc:
https://pr-1773.preview.docs.apify.com/platform/integrations/mcp#configure-tools-for-mcp-server

---------

Co-authored-by: Michał Olender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancurn jancurn jancurn approved these changes

@MQ37 MQ37 MQ37 approved these changes

@TC-MO TC-MO TC-MO approved these changes

Assignees

@jirispilka jirispilka

Labels
t-ai Issues owned by the AI team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jirispilka @apify-service-account @jancurn @MQ37 @TC-MO