Change stack delete behavior to not attempt to delete configured lambda roles. (Closes #787) #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `make test` fails unless the `-modtime` option to `go-bindata` is available. The jteeuwen fork lacks such an option. My assumption is that at some point this project migrated from the jteeuwen fork to the shuLhan fork and failed to update the contributing docs. Also, a minor typo correction.
This makes the behavior of delete stack match create stack (if there's a role configured, skip doing anything regarding the role).
|
|
|
ahh I missed that, thanks! Looks good to me, I'll have a closer look tomorrow and get this in |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #787 for more details.