Skip to content

[REFACTOR][FFI] Phase out old VisitAttrs mechanism #18106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

[REFACTOR][FFI] Phase out old VisitAttrs mechanism #18106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df420b0
[REFACTOR][FFI] Phase out old VisitAttrs mechanism
tqchen Jul 1, 2025
fbd8aab
update local copy move return to fix compiler warning
tqchen Jul 2, 2025
e6dfee5
fix dataflow block
tqchen Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hexagon_launcher/launcher_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ std::string load_text_file(const std::string& file_name) {
std::string buffer(file_size + 1, 0);

in_file.read(&buffer[0], file_size);
return std::move(buffer);
return buffer;
}

void* load_binary_file(const std::string& file_name, void* buffer, size_t buffer_size) {
Expand Down
1 change: 0 additions & 1 deletion ffi/include/tvm/ffi/object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ class Object {
static constexpr int32_t _type_depth = 0;
// extra fields used by plug-ins for attribute visiting
// and structural information
static constexpr const bool _type_has_method_visit_attrs = true;
static constexpr const bool _type_has_method_sequal_reduce = false;
static constexpr const bool _type_has_method_shash_reduce = false;
// The following functions are provided by macro
Expand Down
3 changes: 0 additions & 3 deletions include/tvm/arith/int_solver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ class IntGroupBoundsNode : public Object {
hash_reduce(upper);
}

static constexpr const bool _type_has_method_visit_attrs = false;
static constexpr const bool _type_has_method_sequal_reduce = true;
static constexpr const char* _type_key = "arith.IntGroupBounds";
TVM_DECLARE_FINAL_OBJECT_INFO(IntGroupBoundsNode, Object);
Expand Down Expand Up @@ -174,7 +173,6 @@ class IntConstraintsNode : public Object {
hash_reduce(relations);
}

static constexpr const bool _type_has_method_visit_attrs = false;
static constexpr const bool _type_has_method_sequal_reduce = true;
static constexpr const char* _type_key = "arith.IntConstraints";
TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsNode, Object);
Expand Down Expand Up @@ -240,7 +238,6 @@ class IntConstraintsTransformNode : public Object {
hash_reduce(dst_to_src);
}

static constexpr const bool _type_has_method_visit_attrs = false;
static constexpr const bool _type_has_method_sequal_reduce = true;
static constexpr const char* _type_key = "arith.IntConstraintsTransform";
TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsTransformNode, Object);
Expand Down
Loading
Loading