[BugFix][Relax][Pytorch] Incorrect Handling of In-Place Ops in FX-Based TVM Frontend #17875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshr-h
reviewed
Apr 23, 2025
mshr-h
approved these changes
Apr 23, 2025
|
LGTM. Thanks! |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #17874. Currently, only one in-place operation (bitwise_or_) is affected, and it has been remapped to use self.binary_op_inplace instead of self.binary_op. Going forward, any additional in-place operations (e.g., bitwise_and, bitwise_xor, etc.) should also be explicitly mapped to self._binary_op_inplace to ensure correct handling.