Skip to content

Conversation

hugolatendresse
Copy link
Contributor

Add support for sort.default in exported program translator. There was an existing _sort() function in base_fx_graph_translator.py, but it would return values only. Pytorch returns a tuple of values and indices, so that was corrected

@hugolatendresse hugolatendresse marked this pull request as ready for review April 19, 2025 17:17
@hugolatendresse
Copy link
Contributor Author

cc @MasterJH5574 @tlopex this is ready for review

@tlopex
Copy link
Contributor

tlopex commented Apr 21, 2025

LGTM! Thanks!
Please resolve the conflicts so that we can merge it.
@hugolatendresse

@hugolatendresse
Copy link
Contributor Author

@tlopex @MasterJH5574 the conflicts have been resolved

@MasterJH5574 MasterJH5574 merged commit 2ca6ec8 into apache:main Apr 21, 2025
14 checks passed
@hugolatendresse hugolatendresse deleted the sortdefault branch April 21, 2025 19:43
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
Add support for sort.default in exported program translator.
There was an existing _sort() function in base_fx_graph_translator.py,
but it would return values only. Pytorch returns a tuple of values and
indices, so that was corrected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants