[ISSUE #9730] Merge enableRunningFlagsInFlush and isWriteWithoutMmap configurations #9731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two configurations are typically used together and need to be enabled/disabled simultaneously, so merging them simplifies configuration management. Changes: - Remove enableRunningFlagsInFlush configuration field and its getter/setter methods - Update AllocateMappedFileService to use isWriteWithoutMmap for runningFlags logic - Update CommitLog to use isWriteWithoutMmap for runningFlags logic - Update writeWithoutMmap documentation to explain runningFlags behavior Behavior after merge: - When isWriteWithoutMmap=true: Use RandomAccessFile + set runningFlags to null - When isWriteWithoutMmap=false: Use MappedByteBuffer + use normal runningFlags This eliminates the need to manage two separate but related configurations, reducing the chance of misconfiguration and simplifying the codebase. Change-Id: I053a6ee5c8ba9be825db47940900ce01a8c707b9
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9731 +/- ##
==========================================
Coverage 48.13% 48.13%
- Complexity 12143 12147 +4
==========================================
Files 1313 1313
Lines 93339 93333 -6
Branches 11962 11962
==========================================
+ Hits 44925 44927 +2
+ Misses 42837 42820 -17
- Partials 5577 5586 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two configurations are typically used together and need to be enabled/disabled simultaneously, so merging them simplifies configuration management.
Changes:
Behavior after merge:
This eliminates the need to manage two separate but related configurations, reducing the chance of misconfiguration and simplifying the codebase.
Change-Id: I053a6ee5c8ba9be825db47940900ce01a8c707b9
Which Issue(s) This PR Fixes
Fixes #9730
Brief Description
How Did You Test This Change?