Skip to content

Fix incorrect type hints in Client #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix incorrect type hints in Client #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pulsar/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"""

import logging
from typing import List, Tuple, Optional
from typing import List, Tuple, Optional, Union

import _pulsar

Expand Down Expand Up @@ -627,7 +627,7 @@ def create_producer(self, topic,
properties=None,
batching_type: BatchingType = BatchingType.Default,
encryption_key=None,
crypto_key_reader: CryptoKeyReader = None,
crypto_key_reader: Union[None, CryptoKeyReader] = None,
access_mode: ProducerAccessMode = ProducerAccessMode.Shared,
):
"""
Expand Down Expand Up @@ -804,7 +804,7 @@ def subscribe(self, topic, subscription_name,
properties=None,
pattern_auto_discovery_period=60,
initial_position: InitialPosition = InitialPosition.Latest,
crypto_key_reader: CryptoKeyReader = None,
crypto_key_reader: Union[None, CryptoKeyReader] = None,
replicate_subscription_state_enabled=False,
max_pending_chunked_message=10,
auto_ack_oldest_chunked_message_on_queue_full=False,
Expand All @@ -813,7 +813,7 @@ def subscribe(self, topic, subscription_name,
key_shared_policy=None,
batch_index_ack_enabled=False,
regex_subscription_mode: RegexSubscriptionMode = RegexSubscriptionMode.PersistentOnly,
dead_letter_policy: ConsumerDeadLetterPolicy = None,
dead_letter_policy: Union[None, ConsumerDeadLetterPolicy] = None,
):
"""
Subscribe to the given topic and subscription combination.
Expand Down Expand Up @@ -1005,7 +1005,7 @@ def create_reader(self, topic, start_message_id,
reader_name=None,
subscription_role_prefix=None,
is_read_compacted=False,
crypto_key_reader: CryptoKeyReader = None,
crypto_key_reader: Union[None, CryptoKeyReader] = None,
start_message_id_inclusive=False
):
"""
Expand Down