Skip to content

[feat] PIP-273: Enable hostname verification by default #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[feat] PIP-273: Enable hostname verification by default #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pulsar/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def __init__(self, service_url,
use_tls=False,
tls_trust_certs_file_path=None,
tls_allow_insecure_connection=False,
tls_validate_hostname=False,
tls_validate_hostname=True,
logger=None,
connection_timeout_ms=10000,
listener_name=None
Expand Down Expand Up @@ -432,7 +432,7 @@ def __init__(self, service_url,
Set the path to the trusted TLS certificate file. If empty defaults to certifi.
tls_allow_insecure_connection: bool, default=False
Configure whether the Pulsar client accepts untrusted TLS certificates from the broker.
tls_validate_hostname: bool, default=False
tls_validate_hostname: bool, default=True
Configure whether the Pulsar client validates that the hostname of the endpoint,
matches the common name on the TLS certificate presented by the endpoint.
logger: optional
Expand Down