Skip to content

Use readNextAsync for reader.read_next() #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023
Merged

Use readNextAsync for reader.read_next() #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions src/reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,33 +22,7 @@
namespace py = pybind11;

Message Reader_readNext(Reader& reader) {
Message msg;
Result res;

// TODO: There is currently no readNextAsync() version for the Reader.
// Once that's available, we should also convert these ad-hoc loops.
while (true) {
Py_BEGIN_ALLOW_THREADS
// Use 100ms timeout to periodically check whether the
// interpreter was interrupted
res = reader.readNext(msg, 100);
Py_END_ALLOW_THREADS

if (res != ResultTimeout) {
// In case of timeout we keep calling receive() to simulate a
// blocking call until a message is available, while breaking
// every once in a while to check the Python signal status
break;
}

if (PyErr_CheckSignals() == -1) {
PyErr_SetInterrupt();
return msg;
}
}

CHECK_RESULT(res);
return msg;
return waitForAsyncValue<Message>([&](ReadNextCallback callback) { reader.readNextAsync(callback); });
}

Message Reader_readNextTimeout(Reader& reader, int timeoutMs) {
Expand Down