Skip to content

[MDEPLOY-316] Parent 42 and prerequisite 3.6.3 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[MDEPLOY-316] Parent 42 and prerequisite 3.6.3 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6def64
[MDEPLOY-316] Parent 42 and prerequisite 3.6.3
cstamas Apr 24, 2024
8339674
Quickfix: move to zulu
cstamas Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/maven-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
with:
jdk-distribution-matrix: '[ "zulu" ]'
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ under the License.
<parent>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugins</artifactId>
<version>41</version>
<version>42</version>
<relativePath />
</parent>

Expand All @@ -43,7 +43,7 @@ under the License.
</contributors>

<prerequisites>
<maven>3.2.5</maven>
<maven>3.6.3</maven>
</prerequisites>

<scm>
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/apache/maven/plugins/deploy/AbstractDeployMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ protected void warnIfAffectedPackagingAndMaven(final String packaging) {
* Creates resolver {@link RemoteRepository} equipped with needed whistles and bells.
*/
protected RemoteRepository getRemoteRepository(final String repositoryId, final String url) {
// TODO: RepositorySystem#newDeploymentRepository does this very same thing!
RemoteRepository result = new RemoteRepository.Builder(repositoryId, "default", url).build();

if (result.getAuthentication() == null || result.getProxy() == null) {
Expand Down