Skip to content

feat(aria): add role="img" to chart container element #20050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat(aria): add role="img" to chart container element #20050

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3d974f
feat: add role region to div tag when aria: true
ViniciusCestarii Jun 19, 2024
b15b918
fix: change ARIA role from region to img for accessibility
ViniciusCestarii Jun 20, 2024
64539fe
refactor: move dom.setAttribute('role', 'img') to reduce duplication
ViniciusCestarii Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/visual/aria.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the code here before checking description, so that it doesn't need to be set in two different situations?

if (labelModel.get('description')) {
dom.setAttribute('role', 'img');
dom.setAttribute('aria-label', labelModel.get('description'));
return;
}
Expand Down Expand Up @@ -241,6 +242,7 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
const endSeparator = separatorModel.get('end');
ariaLabel += seriesLabels.join(middleSeparator) + endSeparator;

dom.setAttribute('role', 'img');
dom.setAttribute('aria-label', ariaLabel);
}
}
Expand Down