Skip to content

fix(grid): fix clipping in custom series off by pixel #20043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2024
Merged

fix(grid): fix clipping in custom series off by pixel #20043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1030916
fix: clipping in custom series off by pixel#19993
fandi-1205 Jun 18, 2024
b8a9e08
fix(custom):Clipping in custom series off by 1 pixel #19993
fandi-1205 Jun 27, 2024
243bc2f
fix(custom):The range of the custom clipping path has been modified t…
fandi-1205 Jun 27, 2024
f1f79e4
fix(custom):Modify the range of the clipping path under customized co…
fandi-1205 Jun 27, 2024
d9d5432
...
fandi-1205 Jun 27, 2024
58cb454
...
fandi-1205 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/helper/createClipPathFromCoordSys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function createGridClipPath(
let width = rect.width;
let height = rect.height;

const lineWidth = seriesModel.get(['lineStyle', 'width']) || 2;
const lineWidth = seriesModel.get(['lineStyle', 'width']) || 0;
// Expand the clip path a bit to avoid the border is clipped and looks thinner
x -= lineWidth / 2;
y -= lineWidth / 2;
Expand Down
127 changes: 127 additions & 0 deletions test/clip-custom.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.