-
Notifications
You must be signed in to change notification settings - Fork 2.7k
perf(etcd): refactor some code to improve performance #12011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xuruidong <[email protected]>
@xuruidong Just approved to run the CI |
please run the CI again @juzhiyuan |
Hi @xuruidong, I couldn't find the Re-run button. Can you confirm the failed test cases? ![]() |
I don't think the CI failure is related to the code changes. |
Hi @xuruidong, can you add some descriptive information for PR? |
Hi @xuruidong, please add a PR description so that others can review it better ~ |
Hi @Baoyuantop , the PR description has been added, please help review it. Thanks. |
Please fix the failed ci |
Hi @Baoyuantop ,please trigger the ci |
Hi @Baoyuantop , the ci is not stable, the failed test should be rerun |
Hi @xuruidong, there are still bad CIs that need to be fixed. |
Hi @xuruidong, any updates? |
Hi @Baoyuantop ,please trigger the ci |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
Hi @xuruidong, are you still working on this pull request? There are some failed tests that need to be addressed. |
Description
Fixes # (issue)
Before:
The original code performed a cleanup of
self.values
and rebuiltself.values_hash
by:self.values
nil
valuesvalues_hash
in a separate stepProblems:
Now:
nil
values while keeping the same tablevalues_hash
at the same timeWhy better?
Before:
The original code performed a cleanup of
self.values
and rebuiltself.values_hash
by:self.values
nil
valuesvalues_hash
in a separate stepProblems:
Now:
nil
values while keeping the same tablevalues_hash
at the same timeWhy better?
Checklist