Scope event changes #914

vojtajina · 2012-04-27T17:18:48Z

Things to consider:

e.stopPropagation() during $broadcast stops propagation only for given branch (it does depth-first traverse).
e.stopPropagation() if not allowed throws exception ( noop ?)
do we really want options object rather than just third boolean attribute (allowToStopPropagation)
by default stopPropagation is allowed

Breaks event.cancel() is event.stopPropagation()

vojtajina added 2 commits May 17, 2012 15:47

refactor(scope.$emit): rename event.cancel() to event.stopPropagation()

91db992

Breaks event.cancel() is event.stopPropagation()

feat(scope): add event.preventDefault() and event.defaultPrevented

84542d2

vojtajina merged commit 84542d2 into angular:master May 18, 2012

just-boris mentioned this pull request Aug 25, 2015

feat($rootScope): implement event.stopPropagation() for $broadcast-ed events #12672

Open

Provide feedback