feat(@angular/build): support .test.ts files by default in unit test builder
#31438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t builder The unit test discovery logic previously had hardcoded conventions for `.spec.ts` files. This made it inflexible for projects that use other common patterns, such as `.test.ts`. This change introduces support for `.test.ts` files by default and refactors the discovery logic to be more flexible and maintainable. Key changes: - The `unit-test` builder schema now includes both `**/*.spec.ts` and `**/*.test.ts` in its default `include` globs. - The internal test discovery logic in `test-discovery.ts` is refactored to use a configurable array of test file infixes (`.spec`, `.test`). - This allows the smart-handling of static paths (e.g., `ng test --include src/app/app.component.ts`) to correctly resolve the corresponding test file for both conventions. - JSDoc comments and variable names have been updated to improve clarity and reflect the new, more flexible approach.
angular-robot
bot
added
detected: feature
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test discovery logic previously had hardcoded conventions for
.spec.tsfiles. This made it inflexible for projects that use other common patterns, such as.test.ts.This change introduces support for
.test.tsfiles by default and refactors the discovery logic to be more flexible and maintainable.Key changes:
unit-testbuilder schema now includes both**/*.spec.tsand**/*.test.tsin its defaultincludeglobs.test-discovery.tsis refactored to use a configurable array of test file infixes (.spec,.test).ng test --include src/app/app.component.ts) to correctly resolve the corresponding test file for both conventions.