feat(@angular/build): add application builder karma testing to package #29640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
clydin
force-pushed
the
karma/build-package
branch
6 times, most recently
from
73f9331 to
2b0ad1a
Compare
clydin
added
the
action: review
clydin
force-pushed
the
karma/build-package
branch
3 times, most recently
from
63aebf3 to
aee3fb5
Compare
|
The new builder should be added in https://github.com/angular/angular-cli/blob/main/packages/angular/cli/lib/config/workspace-schema.json as well. |
An `application` only variant of the `karma` builder found within the `@angular-devkit/build-angular` package is now available within the `@angular/build` package as `@angular/build:karma`. This builder will only use the `application` builder found within `@angular/build` and does not provide the `builderMode` option as `application` would be the only valid value. Testing behavior is effectively equivalent to using the `@angular-devkit/build-angular:karma` builder with the `builderMode` option set to `application`. However, several options have been adjusted: * `builderMode` was removed * `fileReplacements` legacy structure (`src`/`replaceWith`) removed * `polyfills` only accepts an array of strings * `loader` has been added * `define` has been added * `externalDependencies` has been added
clydin
force-pushed
the
karma/build-package
branch
from
aee3fb5 to
a7ade01
Compare
jkrems
approved these changes
Feb 17, 2025
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
applicationonly variant of thekarmabuilder found within the@angular-devkit/build-angularpackage is now available within the@angular/buildpackage as@angular/build:karma. This builder will only use theapplicationbuilder found within@angular/buildand does not provide thebuilderModeoption asapplicationwould be the only valid value. Testing behavior is effectively equivalent to using the@angular-devkit/build-angular:karmabuilder with thebuilderModeoption set toapplication. However, several options have been adjusted:builderModewas removedfileReplacementslegacy structure (src/replaceWith) removedpolyfillsonly accepts an array of stringsloaderhas been addeddefinehas been addedexternalDependencieshas been addedsasssub-option forstylePreprocessorOptionshas been addedFrom an implementation perspective, the test finding logic and the application builder integration have been moved to the
@angular/buildpackage and reused by the@angular-devkit/build-angularpackage via the private export of@angular/build.Closes: #28809
Closes: #28321
Closes: #29185