Skip to content

Conversation

alan-agius4
Copy link
Collaborator

tailwind.config.cjs is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes #23236

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 27, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review May 27, 2022 08:28
@alan-agius4 alan-agius4 force-pushed the tailwind-config-cjs branch from 5952fea to ffb94ba Compare May 27, 2022 08:34
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): detect tailwind.config.cjs as valid tailwinds configuration fix(@angular-devkit/build-angular): detect tailwind.config.cjs as valid tailwindcss configuration May 27, 2022
…alid tailwindcss configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes angular#23236
@alan-agius4 alan-agius4 force-pushed the tailwind-config-cjs branch from ffb94ba to 05da2a2 Compare May 27, 2022 11:38
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 27, 2022
@clydin clydin added this to the v14 milestone May 27, 2022
@clydin clydin merged commit ee2e756 into angular:main May 27, 2022
@alan-agius4 alan-agius4 deleted the tailwind-config-cjs branch May 27, 2022 18:09
@L2jLiga
Copy link
Contributor

L2jLiga commented May 28, 2022

Thanks a lot :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for tailwind.config.cjs when detecting tailwind
3 participants