test: add a minimal standalone component application E2E test #23097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
e2e/standalone-test
branch
from
bd816c8 to
9141c84
Compare
clydin
added
the
action: review
pkozlowski-opensource
previously approved these changes
May 10, 2022
dgp1130
previously approved these changes
May 10, 2022
| await ng('build'); | ||
|
|
||
| // Perform the default E2E tests | ||
| await ng('e2e', 'test-project'); |
There was a problem hiding this comment.
We should also consider adding a unit test for standalone and verifying that that works, but we can follow up with and expand this test later, so not a blocking issue for this PR.
A new E2E test has been added that updates a newly generated application to use a standalone component that is bootstrapped with the newly introduced `bootstrapApplication` API. This test is intended to check that the minimal functionality for a standalone-based application functions with the Angular CLI. More expansive tests will be added as standalone features and capabilities are introduced within the Angular CLI.
clydin
dismissed stale reviews from dgp1130 and pkozlowski-opensource
via
c2c137f
clydin
force-pushed
the
e2e/standalone-test
branch
from
9141c84 to
c2c137f
Compare
dgp1130
approved these changes
May 10, 2022
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new E2E test has been added that updates a newly generated application to use a standalone component that
is bootstrapped with the newly introduced
bootstrapApplicationAPI. This test is intended to check thatthe minimal functionality for a standalone-based application functions with the Angular CLI. More expansive
tests will be added as standalone features and capabilities are introduced within the Angular CLI.
Closes #23044