Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented May 2, 2022

An addDependency schematics rule has been added to the newly introduced utility subpath export for the @schematics/angular package.
This new rule allows for adding a package as a dependency to a package.json. By default the package.json located
at the schematic's root will be used. The packageJsonPath option can be used to explicitly specify
a package.json in different location. The type of the dependency can also be specified instead
of the default of the dependencies section by using the type option for either development or peer dependencies.

Will be added to the export path in #23041

@clydin clydin added state: blocked target: major This PR is targeted for the next major release labels May 2, 2022
@clydin clydin added this to the v14 milestone May 2, 2022
@dgp1130 dgp1130 self-requested a review May 2, 2022 17:53
@clydin clydin force-pushed the schematics/utility/dependency branch 3 times, most recently from 63baf75 to 4fc986f Compare May 3, 2022 00:29
@clydin clydin requested a review from dgp1130 May 3, 2022 00:33
dgp1130
dgp1130 previously approved these changes May 3, 2022
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @clydin, glad to get this in!

@clydin clydin force-pushed the schematics/utility/dependency branch from 4fc986f to d77bbc2 Compare May 3, 2022 16:21
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label May 3, 2022
@clydin clydin requested a review from dgp1130 May 3, 2022 16:27
An `addDependency` schematics rule has been added to the newly introduced `utility` subpath export for the `@schematics/angular` package.
This new rule allows for adding a package as a dependency to a `package.json`. By default the `package.json` located
at the schematic's root will be used. The `packageJsonPath` option can be used to explicitly specify
a `package.json` in a different location. The type of the dependency can also be specified instead
of the default of the `dependencies` section by using the `type` option for either development or peer dependencies.
@clydin clydin force-pushed the schematics/utility/dependency branch from d77bbc2 to c8434bb Compare May 3, 2022 16:35
@dgp1130 dgp1130 merged commit 3fa38b0 into angular:main May 3, 2022
@clydin clydin deleted the schematics/utility/dependency branch May 3, 2022 19:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants