Skip to content

Conversation

crisbeto
Copy link
Member

Adds the --standalone flag when generating components, directives or pipes through ng generate.

@alfaproject
Copy link

Isn't this a duplicate of #23024

@crisbeto
Copy link
Member Author

I picked this up from Alex.

@crisbeto crisbeto marked this pull request as ready for review April 24, 2022 09:31
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: @schematics/angular labels Apr 24, 2022
@crisbeto crisbeto force-pushed the standalone-schematics branch from 4f3f2e7 to 717d64b Compare April 24, 2022 09:45
"type": "boolean",
"default": false,
"alias": "sa",
"x-user-analytics": 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is standalone component generation something we want to track with analytics? If so 15 appears to be the only free slot currently.
/cc @mgechev

@clydin clydin added this to the v14 milestone Apr 26, 2022
@crisbeto crisbeto force-pushed the standalone-schematics branch from e323467 to 267cd19 Compare April 26, 2022 13:57
@crisbeto
Copy link
Member Author

I've addressed the feedback.

Adds the `--standalone` flag when generating components, directives or pipes through `ng generate`.
@crisbeto crisbeto force-pushed the standalone-schematics branch from 267cd19 to 19f3d3b Compare April 26, 2022 14:22
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Just need @mgechev & @dgp1130 approval for the analytics.

@clydin clydin requested review from mgechev and dgp1130 April 26, 2022 14:26
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @clydin, was slot 15 used for something else previously? I'm just wondering if there's existing data for this flag? I think I remember that we have a limited number of dimensions we can use, is that this value?

@clydin
Copy link
Member

clydin commented Apr 26, 2022

From the doc (https://github.com/angular/angular-cli/blob/master/docs/design/analytics.md#list-of-all-dimensions), it appears that there are only 20 allowed and number 15 was the only unused value.

@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 27, 2022
@clydin clydin merged commit 7b78b78 into angular:master Apr 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants