-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@schematics/angular): add --standalone to ng generate #23032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Isn't this a duplicate of #23024 |
I picked this up from Alex. |
4f3f2e7
to
717d64b
Compare
717d64b
to
e323467
Compare
"type": "boolean", | ||
"default": false, | ||
"alias": "sa", | ||
"x-user-analytics": 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is standalone component generation something we want to track with analytics? If so 15 appears to be the only free slot currently.
/cc @mgechev
e323467
to
267cd19
Compare
I've addressed the feedback. |
Adds the `--standalone` flag when generating components, directives or pipes through `ng generate`.
267cd19
to
19f3d3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @clydin, was slot 15 used for something else previously? I'm just wondering if there's existing data for this flag? I think I remember that we have a limited number of dimensions we can use, is that this value?
From the doc (https://github.com/angular/angular-cli/blob/master/docs/design/analytics.md#list-of-all-dimensions), it appears that there are only 20 allowed and number 15 was the only unused value. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the
--standalone
flag when generating components, directives or pipes throughng generate
.