Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jun 20, 2019

This options allows to define the crossorigin attribute setting of elements that provide CORS support

By default we set the value to anonymous.

Closes #14743

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jun 20, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review June 20, 2019 14:10
@alan-agius4 alan-agius4 requested a review from clydin June 20, 2019 14:10
clydin
clydin previously approved these changes Jun 26, 2019
@vikerman
Copy link
Contributor

@alan-agius4 - Needs rebase

@vikerman
Copy link
Contributor

What is the documentation impact for this change?

Also are we adding crossorigin="anonymous" by default? Is that necessary?

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Jun 26, 2019

Documentation in AIO will be auto generated when new options are added. ( from JSON Help)

With regards if we should always add it or not maybe we should discuss it further, and see if we should add a none option, as truth to be told it’s not really always necessary.

@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Jun 26, 2019
@clydin
Copy link
Member

clydin commented Jun 27, 2019

Of note is that crossorigin="anonymous" on a script element only has an effect on error reporting within the browser. (ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script)

@filipesilva
Copy link
Contributor

Discussed and opted to use none.

@filipesilva filipesilva removed the needs: discussion On the agenda for team meeting to determine next steps label Jun 27, 2019
@alan-agius4 alan-agius4 requested a review from clydin June 27, 2019 18:15
@alan-agius4 alan-agius4 dismissed clydin’s stale review June 27, 2019 18:15

outdated approval

This options allows to define the crossorigin attribute setting of elements that provide CORS support

Closes #14743
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add support for crossorigin in differential loading

5 participants