Skip to content

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Jul 29, 2025

This pull request refactors the signal provider integration in the application to support both offline and real-time data sources.

Key updates:

  • the signal provider has been made a base class with two childs: MatfileSignalProvider and RealtimeSignalProvider;
  • the signal provider is set at runtime instead at startup;
  • real time features have been introduced and adapted for the new PyQtGraph plotting backend
  • in real time mode, only the needed signals are actually ingested and buffered, instead of ingesting every data streamed by the logger;
    • Note: a mechanism to remove signals from being buffered is still missing;
  • The environment variable list for locating robot models is expanded to include GZ_SIM_RESOURCE_PATH used in the new gazebo sim;
  • Fix on regex string matching for model files

Notes

Other PRs related to the real-time feature will follow this one, which is still limited in its functionality. For example, right now is not possible to plot signals that have been logged after the real-time mode has been enabled.

Superseding PR #80

@xela-95 xela-95 marked this pull request as ready for review September 12, 2025 14:36
@xela-95
Copy link
Member Author

xela-95 commented Sep 12, 2025

I think this is now ready for review :)

Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments :)

@GiulioRomualdi
Copy link
Member

Moreover, there are some conflicts. Could you try to fix them? Thanks a lot!

@xela-95
Copy link
Member Author

xela-95 commented Sep 16, 2025

Review comments addressed :)

@xela-95 xela-95 changed the title Rt capabilities p1 visualizer Add real-time capability to visualizer (part 1) Sep 17, 2025
Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor change I can apply

@GiulioRomualdi GiulioRomualdi merged commit 0224f7c into ami-iit:main Sep 18, 2025
3 checks passed
@GiulioRomualdi
Copy link
Member

PR finally merged!! Thanks a lot @xela-95 @nicktrem for the effort!! This is a huge step for everyone!

@xela-95 xela-95 deleted the rtCapabilitiesP1Visualizer branch September 18, 2025 08:14
@traversaro
Copy link
Contributor

Great, thanks a lot @GiulioRomualdi @xela-95 @nicktrem @Giulero @HosameldinMohamed !

fyi @DanielePucci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants