-
Notifications
You must be signed in to change notification settings - Fork 7
Add real-time capability to visualizer (part 1) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add real-time capability to visualizer (part 1) #100
Conversation
- use raw string for regex to not incur in escaping errors - add type annotations for providers - update use of meshcat_provider.model_path
I think this is now ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments :)
Moreover, there are some conflicts. Could you try to fix them? Thanks a lot! |
Review comments addressed :) |
robot_log_visualizer/signal_provider/realtime_signal_provider.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor change I can apply
Great, thanks a lot @GiulioRomualdi @xela-95 @nicktrem @Giulero @HosameldinMohamed ! fyi @DanielePucci |
This pull request refactors the signal provider integration in the application to support both offline and real-time data sources.
Key updates:
MatfileSignalProvider
andRealtimeSignalProvider
;/yarp-robot-logger/rt_logging
, coherently with the configuration of https://github.com/ami-iit/bipedal-locomotion-framework/blob/a967abf35f24030f61493b3ff2d88a7754fd4fe7/devices/YarpRobotLoggerDevice/app/robots/ergoCubGazeboV1_1/yarp-robot-logger.xml#L19-L23 . This could be set by the user from the preferences panel in the future.GZ_SIM_RESOURCE_PATH
used in the new gazebo sim;Notes
Other PRs related to the real-time feature will follow this one, which is still limited in its functionality. For example, right now is not possible to plot signals that have been logged after the real-time mode has been enabled.
Superseding PR #80