Skip to content

Fixes to RenNet model #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes to RenNet model #189

wants to merge 1 commit into from

Conversation

erfanbyt
Copy link

The PR contains the following fixes:

  1. the Block class wasn't following Python naming style
  2. Block class uses an extra attribute, stride, and it is never used. It can safely be deleted.
  3. _make_layer function and ResNet class are taking Block class as input while there is no need for it and it is accessible to them and no need to be given as input.

Thanks

@erfanbyt
fixed issues with _make_layer function, it was taking unnecessary arg…
3ae8bfe 
…uments. Also fixed naming for block class and removed extra attribute, stride, from the block class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erfanbyt