Skip to content

Fix case where PersistenceMessageSerializer.FromBinary got a null for its type parameter #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix case where PersistenceMessageSerializer.FromBinary got a null for its type parameter #4923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/core/Akka.Persistence.Tests/Serialization/PersistenceMessageSerializerSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,23 @@ public void MessageSerializer_should_serialize_manifest_provided_by_EventAdapter
back.Manifest.Should().Be(p1.Manifest);
}

[Fact]
public void MessageSerializer_should_serialize_events_with_no_manifest_and_null_type()
{
var p1 = new Persistent(new MyPayload("a"), sender: TestActor);
var bytes = _serializer.ToBinary(p1);
var back = _serializer.FromBinary(bytes, null);

back.Should().BeOfType<Persistent>();
var persisted = (Persistent)back;
persisted.Payload.Should().BeOfType<MyPayload>();
persisted.Sender.Should().BeEquivalentTo(TestActor);
var payload = (MyPayload)persisted.Payload;

// Yes, the data isn't "a" but ".a.", the custom serializer added these dots.
payload.Data.ShouldBe(".a.");
}

[Fact]
public void MessageSerializer_should_serialize_state_change_event()
{
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Persistence/Serialization/PersistenceMessageSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ private PersistentFSMSnapshot GetPersistentFSMSnapshot(object obj)

public override object FromBinary(byte[] bytes, Type type)
{
if(type == null) return GetPersistentRepresentation(PersistentMessage.Parser.ParseFrom(bytes));
if (type == typeof(Persistent)) return GetPersistentRepresentation(PersistentMessage.Parser.ParseFrom(bytes));
if (type == typeof(IPersistentRepresentation)) return GetPersistentRepresentation(PersistentMessage.Parser.ParseFrom(bytes));
if (type == typeof(AtomicWrite)) return GetAtomicWrite(bytes);
Expand Down