-
Notifications
You must be signed in to change notification settings - Fork 30
chore: replace Python base image with direct reference (for discussion, do not merge) #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: replace Python base image with direct reference (for discussion, do not merge) #734
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@aj/chore/images/decouple-sdm-image-from-python-base-image#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch aj/chore/images/decouple-sdm-image-from-python-base-image Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the Python connector base image dependency with a direct Python 3.13.7 base image to decouple Python version management between Python connectors and Manifest-Only executions.
- Removes dependency on
airbyte/python-connector-base:4.0.2
- Adds comprehensive base image setup including user management, directory creation, and dependency installation
- Switches to Python 3.13.7-slim-bookworm with SHA256 hash verification
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
PyTest Results (Fast)3 763 tests +1 3 751 ✅ ±0 6m 39s ⏱️ -30s Results for commit 2544605. ± Comparison against base commit eca065f. This pull request skips 1 test.
♻️ This comment has been updated with latest results. |
PyTest Results (Full)3 766 tests 3 754 ✅ 11m 18s ⏱️ Results for commit 2544605. |
Update the Dockerfile to use a direct Python base image instead of copying from the Python connector base image, ensuring better control over the Python version and dependencies.
This will allow us to use newer Python versions in the Builder, for SDM, and for manifest-only connectors.
The Python base image can be separarely updated from now on, without impacting the SDM or Manifest-Only runners.