Skip to content

Conversation

aaronsteers
Copy link
Contributor

Update the Dockerfile to use a direct Python base image instead of copying from the Python connector base image, ensuring better control over the Python version and dependencies.

This will allow us to use newer Python versions in the Builder, for SDM, and for manifest-only connectors.

The Python base image can be separarely updated from now on, without impacting the SDM or Manifest-Only runners.

@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 18:41
@github-actions github-actions bot added the chore label Aug 28, 2025
Copy link

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@aj/chore/images/decouple-sdm-image-from-python-base-image#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch aj/chore/images/decouple-sdm-image-from-python-base-image

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@aaronsteers aaronsteers changed the title chore: replace Python base image with direct reference chore: replace Python base image with direct reference (for discussion, do not merge) Aug 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the Python connector base image dependency with a direct Python 3.13.7 base image to decouple Python version management between Python connectors and Manifest-Only executions.

  • Removes dependency on airbyte/python-connector-base:4.0.2
  • Adds comprehensive base image setup including user management, directory creation, and dependency installation
  • Switches to Python 3.13.7-slim-bookworm with SHA256 hash verification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aaronsteers aaronsteers marked this pull request as draft August 28, 2025 18:41
Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Caution

Review failed

The head commit changed during the review from 0cd02f8 to f586d1d.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aj/chore/images/decouple-sdm-image-from-python-base-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 28, 2025

PyTest Results (Fast)

3 763 tests  +1   3 751 ✅ ±0   6m 39s ⏱️ -30s
    1 suites ±0      12 💤 +1 
    1 files   ±0       0 ❌ ±0 

Results for commit 2544605. ± Comparison against base commit eca065f.

This pull request skips 1 test.
unit_tests.sources.declarative.test_concurrent_declarative_source ‑ test_read_with_concurrent_and_synchronous_streams

♻️ This comment has been updated with latest results.

Copy link

PyTest Results (Full)

3 766 tests   3 754 ✅  11m 18s ⏱️
    1 suites     12 💤
    1 files        0 ❌

Results for commit 2544605.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants