Skip to content

feat(demo): force engine version #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

feat(demo): force engine version #27

merged 2 commits into from
Jun 26, 2025

Conversation

aldogonzalez8
Copy link
Contributor

I had problems running as fetch was not available in Node till versions>18. This should help people trying the widget in the demo.

at /Users/aldogonzalez/dev/airbyte-embedded-widget/demo/server.js:49:22
at Layer.handle [as handle_request] (/Users/aldogonzalez/dev/airbyte-embedded-widget/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/layer.js:95:5)
at next (/Users/aldogonzalez/dev/airbyte-embedded-widget/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/route.js:149:13)
at Route.dispatch (/Users/aldogonzalez/dev/airbyte-embedded-widget/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/route.js:119:3)
at Layer.handle [as handle_request] (/Users/aldogonzalez/dev/airbyte-embedded-widget/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/layer.js:95:5)

Error Details
Error Type: ReferenceError
Error Message: fetch is not defined
File: /Users/aldogonzalez/dev/airbyte-embedded-widget/demo/server.js
Line: 49:22

@aldogonzalez8 aldogonzalez8 self-assigned this Jun 26, 2025
girarda
girarda approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but seems reasonable ✅

@aldogonzalez8 aldogonzalez8 merged commit 0740157 into main Jun 26, 2025
2 checks passed
@aldogonzalez8 aldogonzalez8 deleted the aldogonzalez8/sonar-widget/force-engine-version branch June 26, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@teallarson teallarson Awaiting requested review from teallarson

@quintonwall quintonwall Awaiting requested review from quintonwall

Assignees

@aldogonzalez8 aldogonzalez8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldogonzalez8 @girarda