feat: callback added to demo, add a server, and remove vite dependency #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
changed the title
girarda
approved these changes
Apr 24, 2025
| const loadingEl = document.getElementById("loading"); | ||
| const errorEl = document.getElementById("error"); | ||
| <script type="module"> | ||
| import { EmbeddedWidget } from "https://cdn.jsdelivr.net/npm/@airbyte-embedded/[email protected]/+esm"; |
There was a problem hiding this comment.
note to ourselves: we'll want a way to update this automatically
joeykmh
reviewed
Apr 25, 2025
teallarson
commented
Apr 25, 2025
Comment on lines
11
to
42
| "build": "tsc", | ||
| "prepare": "pnpm run build", | ||
| "format": "prettier --write .", | ||
| "lint": "prettier --check .", | ||
| "test": "jest", | ||
| "test:watch": "jest --watch" | ||
| }, | ||
| "keywords": [ | ||
| "airbyte", | ||
| "embedded", | ||
| "modal", | ||
| "widget", | ||
| "sources", | ||
| "connectors", | ||
| "ui", | ||
| "oauth", | ||
| "authentication", | ||
| "authorization", | ||
| "connect", | ||
| "connector", | ||
| "connectors" | ||
| ], | ||
| "author": "Airbyte", | ||
| "license": "UNLICENSED", | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.12", | ||
| "@types/node": "^20.11.24", | ||
| "eslint": "^9.23.0", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^29.7.0", | ||
| "ts-jest": "^29.1.2", | ||
| "typescript": "^5.3.3" |
There was a problem hiding this comment.
we need quite a bit of this :) adding some back.
teallarson
commented
Apr 25, 2025
package.json
Outdated
| ] | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", |
There was a problem hiding this comment.
@girarda was this intentional? We had a chat a month ago about making this UNLICENSED, so I am not sure about this.
teallarson
commented
Apr 25, 2025
Comment on lines
15
to
21
| "@playwright/test": "^1.42.1", | ||
| "@types/node": "^22.13.14", | ||
| "@vitejs/plugin-basic-ssl": "^2.0.0", | ||
| "dotenv": "^16.4.7", | ||
| "prettier": "^3.5.3", | ||
| "typescript": "^5.3.3", | ||
| "vite": "^5.0.0" |
There was a problem hiding this comment.
same here if we want tests of the demo, we need these :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.