Skip to content

Conversation

reidbarber
Copy link
Member

Fixes the Using implicit actions during rendering is deprecated error in Storybook caused by us using argTypesRegex.

This could be reproduced by typing into the Combobox here: https://react-spectrum.adobe.com/s2/index.html?path=/docs/combobox--docs

Now we pass actions in explicitly. This should also allow us to mock/spy them in interaction tests: https://storybook.js.org/docs/essentials/actions#action-args

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Verify that the story doesn't crash when typing into the Combobox.
Verify that the actions are still shown in the actions tab.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 10, 2025

snowystinger
snowystinger previously approved these changes Sep 10, 2025
@rspbot
Copy link

rspbot commented Sep 10, 2025

@reidbarber reidbarber added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit af10b48 Sep 10, 2025
32 checks passed
@reidbarber reidbarber deleted the storybook-8-args branch September 10, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants