Version 4.17.0 #49
Merged
Version 4.17.0 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorreis
reviewed
Dec 12, 2018
| android { | ||
| compileSdkVersion 26 | ||
| buildToolsVersion "26.0.3" | ||
| compileSdkVersion rootProject.ext.compileSdkVersion |
vitorreis
reviewed
Dec 12, 2018
| project(':react-native-adjust').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-adjust/android') | ||
| include ':react-native-adjust' | ||
| project(':react-native-adjust').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-adjust/android') | ||
| include ':react-native-adjust' |
There was a problem hiding this comment.
Yeah, build scripts which are building and running our example app are making sure this happens each time we run them, but having in mind that it's an example app that we mostly use just to demonstrate how SDK API can be used, we're living with it. Will be addressed in future, but for now, it's like this. But fair point. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSdkVersion()method toAdjustinterface to obtain current SDK version string.compilekeyword in plugin'sbuild.gradlefile intoimplementation(WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api' #47). Thanks to @vitorreis.