Fix dangling else in issuer_or_subject_length (issue #30) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritesh006
force-pushed
the
fix/issuer-or-subject-length-check
branch
2 times, most recently
from
9e608fe to
f73c283
Compare
adafruit#30) Corrected the check when all issuer/subject fields are empty. Previously raised TypeError (misleading), now raises ValueError. Fixes adafruit#30.
ritesh006
force-pushed
the
fix/issuer-or-subject-length-check
branch
from
f73c283 to
e093f2a
Compare
|
Hi @tekktrik Matches existing tests and maintains backward compatibility. Added a clear error message for easier debugging. Note: While ValueError might be more semantically correct, TypeError is kept to align with the current API and CI expectations. Kindly requesting your review when you get a chance 🙏 |
|
dupe of #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the logic in adafruit_atecc/adafruit_atecc_asn1.py where the issuer_or_subject_length function incorrectly raised a TypeError whenever the common parameter was empty. The previous implementation had a dangling else: attached to the if common block, so an error was raised even when other fields were provided.
The fix removes the dangling else and instead raises a TypeError only when no certificate fields have been supplied (i.e., when tot_len == 0). This behaviour matches the intended functionality described in issue #30.
This PR therefore resolves #30.