Support config of git (diff) flags

[aaronhallaert]

No description provided.

[mmirus]

Thanks for working on this, @aaronhallaert! Unfortunately, I wasn't able to get it working.

Take this command syntax, which I think corresponds to what's used by diff_commit_file:

git diff <prev commit hash>:<file path> <commit hash>:<file path>

On the command line, adding flags like this works:

git -c delta.side-by-side=false diff <prev commit hash>:<file path> <commit hash>:<file path>

I tried to replicate this with the new args, but was unable to:

    local telescope = require("telescope")
    telescope.setup({
      -- ...
      extensions = {
        advanced_git_search = {
          -- git_flags = { "-c", "delta.side-by-side=false" }, -- `git: 'delta.side-by-side=false' is not a git command. See 'git --help'.`
          -- git_flags = { "-c delta.side-by-side=false" }, -- `unknown option: -c delta.side-by-side=false`
          -- git_flags = { "-c delta.side-by-side=" }, -- same as above
          git_flags = { "-cdelta.side-by-side=false" }, -- same as above

          -- I also tried this to show it's not a delta thing:
          -- git_flags = { "-c", 'core.pager=""' }, -- `git: 'core.pager=""' is not a git command. See 'git --help'.`
        },
      },
    })
    -- INFO: seems we must load this extension *after* telescope setup runs:
    telescope.load_extension("advanced_git_search")

You can see the output I got next to each form I attempted.

I also tried git_diff_flags, just in case, but also had no luck with that.

Please let me know if I should try anything else!

[aaronhallaert]

@mmirus Thanks for trying it out and giving me a specific example to test with. I inserted the provided flags in the wrong order 😅 Now it should work with this -- git_flags = { "-c", "delta.side-by-side=false" },. Let me know if you find any other bugs.
BTW: I force pushed, so you'll probably need to pull with rebase

[mmirus]

Awesome! It's working now.

One other thing I ran into: you must run the Telescope setup before loading the extension for the flags to take effect. It might be helpful to make that clear in the README.

Thank you for implementing this!