Report all missing bindings at once

[kevinguitar]

Description

I found that metro only reports 1 missing binding at once, and it slows down the development iteration on building new features for us. For example, if a new feature has 10 missing bindings, it requires 10 compilation to catch them all.

Self-contained Reproducer

@DependencyGraph
interface TestGraph {
    val dependency: Dependency
}

@Inject
class Dependency(
    val int: Int,
    val string: String,
    val long: Long,
    val boolean: Boolean,
)

This code fails with

[Metro/MissingBinding] Cannot find an @Inject constructor or @Provides-annotated function/property for: kotlin.Int

But I expect metro will report all 4 missing bindings, does that make sense?

Metro version

0.5.1

Context

No response

[ZacSweers]

It does make sense, though I'm going to reclassify this as an enhancement as the current design is somewhat intentional. There is a bit of a halting problem with reporting missing bindings in DI frameworks that I'd like to avoid (i.e. the 500 error snowball for something simple being wrong). There is a toe-hold for this already in place that just doesn't report all at once yet, but I may set a (configurable) default max.

[kevinguitar]

Gotcha, can you point me to the place that refrains from reporting all errors? I might need to bypass it and release it internally 🙏

[ZacSweers]

There's not a place where it "refrains" per se, just a TODO in the place where it would be implemented. I'm on mobile but take a look at where IrBindingGraph calls seal(). Somewhere around there it returns back a list of missing bindings as collected during graph populating.