[Fix] Edit the gym-unity Readme to fix some issue in the sample code #5331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcoh
reviewed
May 10, 2021
gym-unity/README.md
Outdated
| [here](../docs/Learning-Environment-Executable.md). Add the following code to | ||
| [here](../docs/Learning-Environment-Executable.md). Note that for the DQN baseline, | ||
| the environment must have a single visual observation, a single discrete action and | ||
| a single Agent in the scene. |
There was a problem hiding this comment.
maybe adding the reason for this will prevent people asking why in the future
ervteng
reviewed
May 10, 2021
andrewcoh
reviewed
May 10, 2021
andrewcoh
approved these changes
May 10, 2021
ervteng
approved these changes
May 10, 2021
Co-authored-by: andrewcoh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Modified the gym-unity readme to fix some issues with the code (The API for the gym wrapper changed)
This should fix some of the issues reported in #5330
We need to decide what to do with this Readme since the GridWorld environment is now much more complex (with task parametrization)
I haven't tested dopamine training, only amde sure that the training of baseline DQN and PPO2 starts and does a few updates.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
MLA-1968
Types of change(s)
Checklist
Other comments