Skip to content

Use Debug.AssertFormat in Actuator Manager #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Use Debug.AssertFormat in Actuator Manager #4877

merged 1 commit into from
Jan 22, 2021

Conversation

surfnerd
Copy link
Contributor

Proposed change(s)

Lazily format a string for an assert message in DEBUG mode.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe) - Reduce debug GC.Alloc for Debug Asserts

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@surfnerd surfnerd requested a review from chriselion January 21, 2021 22:32
@surfnerd surfnerd self-assigned this Jan 21, 2021
@chriselion chriselion mentioned this pull request Jan 22, 2021
Merged
@surfnerd surfnerd merged commit 66c2931 into master Jan 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-debug-assert-format branch January 22, 2021 03:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@surfnerd surfnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surfnerd @chriselion