Skip to content

[bug-fix] Normalization update with SeparateActorCritic, SAC bugfixes #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 8, 2020
Merged

[bug-fix] Normalization update with SeparateActorCritic, SAC bugfixes #4722

merged 10 commits into from
Dec 8, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Dec 8, 2020

Proposed change(s)

Fix two issues with hybrid actions:

  • Normalization of the critic was not being updated with SeparateActorCritic.
  • In SAC, stop gradient on Q function during value update, and other small performance tweaks.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from andrewcoh December 8, 2020 18:07
andrewcoh
andrewcoh approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Unity-Technologies Unity-Technologies deleted a comment from ervteng Dec 8, 2020
@ervteng ervteng merged commit 71e075d into develop-hybrid-action-staging Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-export-clipping-sac branch December 8, 2020 21:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh Awaiting requested review from andrewcoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @andrewcoh