Skip to content

Add fire to test_simple_rl.py #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Add fire to test_simple_rl.py #4378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23e8d72
add test_simple_rl tests to torch
andrewcoh Aug 18, 2020
6635413
revert tests
andrewcoh Aug 18, 2020
e490c10
Fix of the test for multi visual input (#4379)
vincentpierre Aug 19, 2020
c913ca8
[add-fire] Fix ResNet export (#4380)
Aug 19, 2020
1c04d88
Adding seeds to simple RL tests (#4383)
vincentpierre Aug 19, 2020
5e2817f
Merge branch 'develop-add-fire' into develop-add-fire-test-simple-rl
Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ml-agents/mlagents/trainers/policy/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ def __init__(
self.vis_obs_size = sum(
1 for shape in behavior_spec.observation_shapes if len(shape) == 3
)
self.vis_obs_shape = (
[shape for shape in behavior_spec.observation_shapes if len(shape) == 3][0]
if self.vis_obs_size > 0
else None
)
self.use_continuous_act = behavior_spec.is_action_continuous()
self.num_branches = self.behavior_spec.action_size
self.previous_action_dict: Dict[str, np.array] = {}
Expand Down
2 changes: 2 additions & 0 deletions ml-agents/mlagents/trainers/tests/test_simple_rl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
RewardSignalType,
EncoderType,
ScheduleType,
FrameworkType,
)
from mlagents.trainers.environment_parameter_manager import EnvironmentParameterManager
from mlagents_envs.side_channel.environment_parameters_channel import (
Expand All @@ -53,6 +54,7 @@
summary_freq=500,
max_steps=3000,
threaded=False,
framework=FrameworkType.TENSORFLOW,
)

SAC_CONFIG = TrainerSettings(
Expand Down
Loading