Skip to content

Updated the badge’s link to point to the newest doc version #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2020
Merged

Updated the badge’s link to point to the newest doc version #4131

merged 2 commits into from
Jun 17, 2020

Conversation

xiaomaogy
Copy link
Contributor

Proposed change(s)

Updated the link for the badge to point to the newer version

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@xiaomaogy xiaomaogy requested a review from vincentpierre June 17, 2020 00:16
@chriselion
Copy link
Contributor

I updated the release checklist - we should be updating any release_*_docs links in each release.

chriselion
chriselion suggested changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you search the code for all instances of release_2_docs and replace it with release_3_docs? The only exception (I think) should be the table with all of the releases.

@xiaomaogy xiaomaogy requested a review from chriselion June 17, 2020 05:43
@xiaomaogy xiaomaogy merged commit 3d2204d into master Jun 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-badge-version branch June 17, 2020 19:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaomaogy @chriselion