added the note about the windows bug #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattar
suggested changes
Oct 10, 2018
docs/Training-ML-Agents.md
Outdated
| On Mac and Linux platform, you can press Ctrl+c to terminate your training | ||
| early, the model will be saved as if you set your max_steps to the current step. | ||
| (Note: There is a known bug on Windows that causes the saving of the model to | ||
| fail when you early terminate the training, it's recommended to wait until Step |
There was a problem hiding this comment.
parameter you set) --> parameter you set.)
Just add a period.
|
Hi @mmattar, thanks for the comments, I've fixed them. |
mmattar
approved these changes
Oct 11, 2018
|
Is the note still needed, considering the #1558 fix? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.